search

jovany-wang / metable

A distributed table-like metadata service for managing your large scale cluster with highly performance.
7 stars 8 forks source link

Support CreateTable RPC #46

Closed dzh-cmd closed 2 years ago

dzh-cmd commented 2 years ago

Add a service to create tables between clients and servers. When the client calls this RPC, the client needs to pass in the table name and field description, and the server will store the information of the table as metadata.

dzh-cmd commented 2 years ago

I have fixed the error about "segmentation fault (core dumped)".

jovany-wang commented 2 years ago

Could you also add your PR description?

jovany-wang commented 2 years ago

Approved. Will merge it once lint fixed.

dzh-cmd commented 2 years ago

Resubmitted

------------------ 原始邮件 ------------------ 发件人: "jovany-wang/metable" @.>; 发送时间: 2022年3月4日(星期五) 下午5:41 @.>; @.**@.>; 主题: Re: [jovany-wang/metable] Support CreateTable RPC (PR #46)

@jovany-wang approved this pull request.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.Message ID: @.***>

dzh-cmd commented 2 years ago

Are there any problems with the code-format.sh script? Here are some suggestions for me. However, the indentation length of the file should be 2 instead of 4, right?

message Field {

jovany-wang commented 2 years ago

Are there any problems with the code-format.sh script? Here are some suggestions for me. However, the indentation length of the file should be 2 instead of 4, right?

No, I believe it's 4. image

jovany-wang commented 2 years ago

Let me merge this first and then I'll format the whole project in the next PR.