search

joven-health-mike / juno-react

A virtual therapy platform designed for K-12 schools.
0 stars 0 forks source link

[draft] Feature/create appt form specs #149

Closed zoe-gonzales closed 1 year ago

joven-health-mike commented 1 year ago

Hey @zoe-gonzales, before working on this much more, check out #148.

I'm making some significant changes to how the views are populated, using Material UI library instead of our own custom components.

I had to change some of the tests to grab the correct view.

We're almost definitely moving forward with merging that PR, so it might be good to rebase this branch onto my branch and work from there. Thanks!

zoe-gonzales commented 1 year ago

Hey @zoe-gonzales, before working on this much more, check out #148.

I'm making some significant changes to how the views are populated, using Material UI library instead of our own custom components.

I had to change some of the tests to grab the correct view.

We're almost definitely moving forward with merging that PR, so it might be good to rebase this branch onto my branch and work from there. Thanks!

Sorry the delay! That sounds great! I'll do that. Hopefully with Jest it won't require a ton of changes 🤞

zoe-gonzales commented 1 year ago

@joven-health-mike Thanks for the heads up on that. Given how much the component has changed, I think it might make the most sense to start over from scratch on the tests rather than go off what I had before. From a unit test perspective, it could be helpful to break the form into separate components from the dialogs so that the inputs could be tested separately from dialog actions, such as dismissing the modal.

IMO, I think it would probably be more valuable in the long run to test these pages with integration specs since these creation flows are a central part of the app. I've heard good things about Cypress for end-to-end tests. I'm not sure how much time you want to invest in that at the moment though.