search

joven-health-mike / juno-react

A virtual therapy platform designed for K-12 schools.
0 stars 0 forks source link

Add ID to data types & clean up string comparisons #25

Closed joven-health-mike closed 2 years ago

joven-health-mike commented 2 years ago

There are several spots in the code that are returning strings instead of IDs. This will cause problems and needs to be fixed.

For example, SelectLists take in a list of strings to display in the drop-down. When one of those strings is selected, we get a callback with the string that was selected. This may not be the best way to do things, because we might have duplicates (e.g. two students with the same name).

Another example, when the "XButton" is clicked on any list, we get a callback with a string for which table row had the XButton clicked. If we delete data based on a string name, we would delete any students that have the same name.

joven-health-mike commented 2 years ago

This is all fixed in PR #28