search

jovibor / HexCtrl

Fully-featured Hex Control written in C++/MFC.
Other
164 stars 61 forks source link

Proposed code page dialog #17

Closed datasynergyuk closed 4 years ago

datasynergyuk commented 4 years ago

Add code page selection dialog and associated menu item and internal command.

Also, call SetCodePage() on creation to ensure consistent UI and remove "ASCII" magic string.

jovibor commented 4 years ago

This is about to be implemented in a slightly different way.

datasynergyuk commented 4 years ago

Thank you. Your changes is superior because it shows the code pages which are not currently supported and prevents them being selected which my suggestion did not account for. My only remaining suggestion is that SetEncoding should not describe non-ASCII code page as "ASCII". e.g. Suggest change

wstrFormat = L"ASCII (%i)";

to something link:

wstrFormat = L"CP (%i)";