search

jovibor / HexCtrl

Fully-featured Hex Control written in C++/MFC.
Other
167 stars 58 forks source link

Add search results as distinct bookmarks #22

Closed datasynergyuk closed 4 years ago

datasynergyuk commented 4 years ago

Please can I suggest the following improvement. This adds the selected search results as distinct bookmarks rather than a single bookmark.

Logic: Adding multiple search results as a single bookmark is clever but not very compatible with the other bookmark features. The bookmark manager only shows a single entry, the individual sub-spans cannot be viewed/edited in the UI and the next/previous bookmark feature doesn't work. It is probably more convenient to the user to have individual bookmarks that can be viewed and manipulated in the usual way.

jovibor commented 4 years ago

Ofc you're right. I just mixed it up, now it's fixed.