jovotech / jovo-cli

🛠 Command Line Interface for the Jovo Framework: Makes voice experience deployment a breeze, including features like local development and staging.
https://www.jovo.tech/marketplace/jovo-cli
Apache License 2.0
57 stars 31 forks source link

jovo get fails with "TypeError: Cannot read property 'uri' of undefined" #25

Closed serg06 closed 6 years ago

serg06 commented 6 years ago
> jovo get alexaSkill --skill-id <redacted>

? Found existing project files. How to proceed? Overwrite
   × Getting Alexa Skill project for ASK profile default
     -> Cannot read property 'uri' of undefined
     Getting Alexa Skill model files and saving to /platforms/alexaSkill/models

{ TypeError: Cannot read property 'uri' of undefined
    at Object.getSkillSimpleInformation (C:\Users\redacted\AppData\Roaming\npm\node_modules\jovo-cli\helper\alexaUtil.js:413:65)
    at p.then.then.then.then.then.then (C:\Users\redacted\AppData\Roaming\npm\node_modules\jovo-cli\commands\tasks.js:103:57)
    at <anonymous>
    at process._tickDomainCallback (internal/process/next_tick.js:228:7)
  context:
   { skillId: '<redacted>',
     locales: [ 'en-US' ],
     type: 'alexaSkill',
     target: 'all',
     projectId: undefined,
     stage: undefined,
     askProfile: 'default',
     info: 'Info: ' } }

I just set up ASK CLI by following the instructions to a dot. Not sure why it's not working, jovo new/init/build work fine.

Jovo CLI Version: 1.1.1

jankoenig commented 6 years ago

Thanks. Did you set an endpoint for the Skill already? The CLI seems to be expecting that an endpoint is already set.

serg06 commented 6 years ago

I have it set to an Amazon Lambda ARN with only the "Default Region" filled in.

jankoenig commented 6 years ago

Hi there, thanks for helping us discover a bug: For me, it throws an error when the endpoint is empty. Will look into this with @aswetlow.

However, it works for me when I use a Lambda ARN. Will get back to you when we have investigated the problem.

serg06 commented 6 years ago

Thank you!

aswetlow commented 6 years ago

Can't reproduce it with a Lambda ARN. Fixed the issue (in v1.1.3) when the endpoint is empty. Could you try it again, @serg06 ?

serg06 commented 6 years ago

Works in 1.1.3 for me (though I have changed a lot of settings by now), thanks!