search

jovotech / jovo-cli

🛠 Command Line Interface for the Jovo Framework: Makes voice experience deployment a breeze, including features like local development and staging.
https://www.jovo.tech/marketplace/jovo-cli
Apache License 2.0
57 stars 31 forks source link

👽 Update Serverless `frameworkVersion` property #327

Closed fboerncke closed 2 years ago

fboerncke commented 2 years ago

added a hint to make sure that you have the right entry for the "frameworkVersion" property in the serverless.yaml file

aswetlow commented 2 years ago

Hey @fboerncke
Thank you for the PR. I think it would also make sense to change the frameworkVersion in the boilerplate code to version 3. https://github.com/jovotech/jovo-cli/blob/v4/latest/integrations/target-serverless/src/index.ts#L25

What do you think?

fboerncke commented 2 years ago

I agree. I changed the setting in my generated file to "3" in my environment and it worked fine.

My only concern with this is that those users who update their Jovo installation without updating their serverless installation wil run into the same problem when creating new projects that I had last week. The error message is not very helpful if the framework version numbers do not match.

Finally though I believe that using the latest version numbers as default makes sense, especially if you plan to support the new AWS Function URL Lambdas in some future version of Jovo.

aswetlow commented 2 years ago

Awesome. Would you mind also updating the version?

fboerncke commented 2 years ago

OK, I'll do that soon ...

fboerncke commented 2 years ago

I added the modifications regarding V2 ==> V3 to the existing pull request.

jankoenig commented 2 years ago

Hi @fboerncke, thanks a lot for your updates! I wanted to make a few additional changes to the documentation. For that, could you please create a topic branch (e.g. v4/serverless-version, ideally based on the v4/dev branch) and push the updates to that one?

Also, I switched the target branch from v4/latest to v4/dev. Learn more here: https://www.jovo.tech/docs/contributing#branches

Thank you!

fboerncke commented 2 years ago

Hi @jankoenig, currently I am on holiday and will return to the keyboard around next Wednesday. I can take care of your request then. But if it is somehow urgent then feel free to drop/refuse my PR and introduce my some changes into your branch to speed up the process. Bye, Frank

jankoenig commented 2 years ago

Thank you @fboerncke. I merged your changes into a new branch and created a new PR (#329) from it. This way, your changes stay connected to your account. Thanks for your help 🎉 enjoy your holidays