jovotech / jovo-cli

🛠 Command Line Interface for the Jovo Framework: Makes voice experience deployment a breeze, including features like local development and staging.
https://www.jovo.tech/marketplace/jovo-cli
Apache License 2.0
57 stars 31 forks source link

:label: updated alexa Plugin Config Files type #355

Closed sadlowskij closed 1 year ago

sadlowskij commented 1 year ago

Proposed changes

This is kind of an extra to this as that was not enough to make it work. Using the SkillManifest type of the ask-smapi-model package this should work now:

import { v1 } from 'ask-smapi-model/index';

//...

const alexaCliConfig: AlexaCliConfig = {
  skillId: this.config.skillId,
  askProfile: this.config.askProfile,
  locales: this.config.locales,

  files: {
    'skill-package/skill.json': {
      // buildManifest with return type DeepPartial<v1.skill.Manifest.SkillManifest>
      manifest: this.buildManifest(),
    },
  },
};

Types of changes

Checklist

sadlowskij commented 1 year ago

Maybe instead of just allowing string would it make sense to just allow any primitve types? I'm not sure, why this is so restrictive here