jovotech / jovo-cli

🛠 Command Line Interface for the Jovo Framework: Makes voice experience deployment a breeze, including features like local development and staging.
https://www.jovo.tech/marketplace/jovo-cli
Apache License 2.0
57 stars 31 forks source link

Build for Alexa doesn't use invocationName override: en.json -> en-US.json #46

Closed rmtuckerphx closed 3 years ago

rmtuckerphx commented 6 years ago

I'm submitting a...

Expected Behavior

Executing the following: jovo build -p alexaSkill --stage dev

When the app.json override is set with an invocation override:

    "dev": {
      "host": {
        "lambda": {
          "arn": "arn:aws:lambda:us-east-1:...",
          "askProfile": "sample-dev"
        }
      },
      "alexaSkill": {
        "skillId": "amzn1.ask.skill....",
        "languageModel": {
          "en-US": {
            "invocation": "skillname dev" #OVERRIDE
          }
        }
      }

And the source model is in: models/en.json (NOTE: not en-US.json) And the destination model is in: platforms/alexaSkill/models/en-US.json

The override should be set in: platforms/alexaSkill/models/en-US.json

{
    "interactionModel": {
        "languageModel": {
            "invocationName": "skillname dev",

Current Behavior

The override instead is NOT applied in: platforms/alexaSkill/models/en-US.json

{
    "interactionModel": {
        "languageModel": {
            "invocationName": "skillname",

If I rename the source model to: models/en-US.json then the override works.

Error log

No error log

Your Environment

rmtuckerphx commented 6 years ago

The build log is:

C:\dev\sample-jovo>jovo build -p alexaSkill --stage dev

   √ Updating /platforms/alexaSkill
     √ Updating Alexa project files
       √ skill.json
     √ Updating Alexa Interaction Model based on Jovo Language Model in /models
       √ en

  Build completed.

Should the last step be en-US instead of en?

rmtuckerphx commented 6 years ago

The build log should include which stage was built as well as if overrides were applied for skill.json (info) or en-US.json (model)

rubenaeg commented 3 years ago

Closing this due to inactivity. Since you're building the locale en, overrides for en-US won't be triggered. If the issue still persists with en, feel free to reopen.