Sometimes the detail property in a ask error (e. g. of a deploy) can be just an empty object. This happens for example, if I try to deploy while the build is still going on. It throws a 409 with an empty detail:
This will lead to an error, trying to access payload.detail.response.message. This error then is being caught here which leads to the whole json bein output, instead of the message being retrieved:
With this fix it will correctly be retrieved:
I worked on this before the other change to getAskError was merged (which catches errors in the ask error retrieval process). Before this merge, the error was more severe as it completely dropped the actual error message, now it is more of a question of how it is displayed. However this still throws an error currently in a place where it is avoidable.
Types of Changes
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist
[ ] My code follows the code style of this project
[ ] My change requires a change to the documentation
Proposed Changes
Sometimes the
detailproperty in a ask error (e. g. of a deploy) can be just an empty object. This happens for example, if I try to deploy while the build is still going on. It throws a 409 with an emptydetail:This will lead to an error, trying to access
payload.detail.response.message. This error then is being caught here which leads to the whole json bein output, instead of the message being retrieved:With this fix it will correctly be retrieved:
I worked on this before the other change to getAskError was merged (which catches errors in the ask error retrieval process). Before this merge, the error was more severe as it completely dropped the actual error message, now it is more of a question of how it is displayed. However this still throws an error currently in a place where it is avoidable.
Types of Changes
Checklist