search

jovotech / jovo-framework

🔈 The React for Voice and Chat: Build Apps for Alexa, Messenger, Instagram, the Web, and more
https://www.jovo.tech
Apache License 2.0
1.68k stars 309 forks source link

Port AlexaResponse.isDialogXXX functions to v2 #347

Closed IGx89 closed 5 years ago

IGx89 commented 5 years ago

I'm submitting a...

Desired Behavior

Would it be possible to bring back all the res.isDialogXXX functions to Jovo v2 that were in v1? Examples: isDialogDelegate, isDialogElicitSlot, etc. I've ported my app to v2 but still have a number of unit tests commented out due to this missing functionality. If there's a different/better way to do the same thing in v2 I'd love to know -- had no luck finding it yet.

I'd roll my own but there's a decent amount of logic in the original methods (https://github.com/jovotech/jovo-framework/blob/v1/lib/platforms/alexaSkill/alexaResponse.js#L904) that it seems better suited to the framework.

Thanks!

aswetlow commented 5 years ago

I can do it next week. But feel free to make a pull request 😅

aswetlow commented 5 years ago

Added in v2.1