search

jovotech / jovo-framework

🔈 The React for Voice and Chat: Build Apps for Alexa, Messenger, Instagram, the Web, and more
https://www.jovo.tech
Apache License 2.0
1.68k stars 309 forks source link

using app instead of this in indexGoogleAssistantCards example code? #58

Closed MiKiTxn closed 6 years ago

MiKiTxn commented 6 years ago

Hi, in the file jovo-framework-nodejs/examples/google_action_specific/indexGoogleAssistantCards.js

in the handler for "ON_ELEMENT_SELECTED" it the 'this' element used, shouldn't that be the 'app' element?

well, I did not execute the code, just noticed from reviewing.

Thank you! Best Regards Michael

jankoenig commented 6 years ago

Hi Michael, good catch! We're currently restructuring the code. In the future, for the app logic (inside the handler), we will always use this, and app only for the configuration. Currently, both works.