jow- / luci-ng

LuCI on Angular
84 stars 26 forks source link

luci2-io-helper: bugfix buckup script read timeout #11

Closed feckert closed 8 years ago

feckert commented 8 years ago

Reading files from stdin will block for ever. The uhttpd is killing the backup process after script_timeout.

Switching read to non blocking mode and add a waitpid for the slave process does not end in a script_timeout anymore.

Signed-off-by: Florian Eckert Eckert.Florian@googlemail.com

jow- commented 8 years ago

@feckert - thanks for keeping track of it and sorry that I wasn't able to help earlier, the change looks sane to me but it would be great if you could clean up the white space a bit. Put a space before and after while, put a space between if and (, no padding spaces within the condition.

feckert commented 8 years ago

Hello @jow-

I hope i have it made accurate now :-)

jow- commented 8 years ago

I merged this manually with two slight whitespace changes - thanks!