search

jow- / luci-ng

LuCI on Angular
84 stars 26 forks source link

Dubplicate code (luci2 and rpc-sys) #17

Closed feckert closed 5 years ago

feckert commented 8 years ago

@jow-

I have seen in the C sources of luci2-rpc-base that there are the same functions implemented as in rpc-sys. (upgrade_start, upgrade_clean. upgrade_test, factory, reboot and password). I have written the Sysupgrade Modul (ready for PR) but i don´t know which rpc backend I should use (luci2 or rpc-sys)?

If you ask me :-) I would use the rpc-sys calls, because they are more general and not luci2 specific. If so the Makefile for luci2-ui-base must be extended with rpc-sys dependency. and the duplicated code in luci2 should be deleted.

Kind regards

Flo

jow- commented 8 years ago

Yes, using the rpc-sys namespace is preferred. I'll see when I get around to kill the duplicate code.