search

jow- / luci-ng

LuCI on Angular
84 stars 26 forks source link

RFC: use node/gulp as build system #31

Closed ianchi closed 7 years ago

ianchi commented 7 years ago

Hi @jow- This a RFC to use Node.js/Gulp as the build system for the web frontend. It includes changes on dependencies and Makefiles, and only a stub for the gulpfile. Not much of the potential is yet used, until we agree on a direction, as some more changes are needed. The only actual functionality added so far is a web server for development with a proxy that forwards RPC's to the router. Useful for quick testing. Many more functionalities could easily be added to this schema: linting / concatenation + minification of js / add prefixes to css / use templateCache to develop directives in Html and later convert to js (much easier to edit) ....

I think that it would be best to slightly change the folder structure. For this RFC I only solved it with a symlink, but a more permanent definition is needed before merging this. With this proposed structure, Gulp can be manually used first on the "src" folders while developing, and later again by the LEDE make process to generate the final package.

I'll be sending a separate PR to the Packages repo to update the Nodejs version to the current LTS one.

Signed-off-by: Adrian Panella ianchi74@outlook.com

ghost commented 7 years ago

I think gulp is a great idea. @ianchi seems you are no longer supporting this argument, can I ask why?

ianchi commented 7 years ago

Sorry, I forgot to leave a notice before closing the PR. With some modifications this has already been merged, and I'll finish the build process soon.