jow- / luci-ng

LuCI on Angular
84 stars 26 forks source link

RFC: Switch to Angular Material #35

Closed ianchi closed 7 years ago

ianchi commented 7 years ago

This is a first step into switching from Boostrap to Angular Material, and still work in progress. As Boostrap is not yet removed, there is a "regression" in the look & feel, as both libraries' css conflict.

The main changes are:

a) Add Material Design dependency. All framework related components/services (side menu / toolbar ...) have been developed in their own module, in a separate repo Angular Material Framework. As they are generic, it could be reused in other web projects and so benefit from other contributors.

b) Change login from heartbeat polling to an interceptor approach. It only prompts when there is an authentication error, and resend the request after successful login, making it transparent to the app.

c) Change the spinner to a less obtrusive one. Instead of explicitly invoking it, show it using an http interceptor.

No change from Boostrap has yet been done to any view, outside the general framework.

jow- commented 7 years ago

Build & runtime tested - LGTM! Please proceed :)

ianchi commented 7 years ago

Updated: Moved amFramework to this repo Updated gulpfile: