search

jow- / luci-ng

LuCI on Angular
84 stars 26 forks source link

rpc-base: fix passwd path #57

Closed ianchi closed 5 years ago

ianchi commented 5 years ago

@jow- I’m not sure if this goes for all targets, but in my boxes passwd is located in /bin/ and not in /usr/bin/, so now I always get a 4- not found error response from ubus.

ianchi commented 5 years ago

Perhaps, as stated in #17, it should be better to just use rpc-sys (which by the way, uses /bin/passwd) and remove this duplicate functionality from luci2.system. I can change this PR to do that. @jow- what do you think?

jow- commented 5 years ago

Yes, let's move to rpc-sys - it is a partial fork of the luci2 namespace plugin anyway.

ianchi commented 5 years ago

ok, will change to use rpc-sys and eventually will remove unused methods in luci2 namespace