joweich / chat-miner

Parsers and visualizations for chats
MIT License
567 stars 56 forks source link

Added simple usage for NLP package to ReadMe #114

Closed smty2018 closed 10 months ago

smty2018 commented 11 months ago

Solves 1st job for issue #112

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d27bcb0) 61.23% compared to head (5015e03) 63.17%. Report is 2 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #114 +/- ## ========================================== + Coverage 61.23% 63.17% +1.94% ========================================== Files 2 2 Lines 325 315 -10 ========================================== Hits 199 199 + Misses 126 116 -10 ``` | [Flag](https://app.codecov.io/gh/joweich/chat-miner/pull/114/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Weich) | Coverage Ξ” | | |---|---|---| | [unittests](https://app.codecov.io/gh/joweich/chat-miner/pull/114/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Weich) | `63.17% <ΓΈ> (+1.94%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Weich#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1 file with indirect coverage changes](https://app.codecov.io/gh/joweich/chat-miner/pull/114/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Weich)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

smty2018 commented 11 months ago

@joweich can you please review this PR?

smty2018 commented 11 months ago

@smty2018 Only one minor comment πŸ™‚ do you plan to address the other acceptance criteria of the issue in this PR as well?

I will work on the example results part and try to submit them in another separate PR for the examples by max tomorrow.

And really thank you for your guidance @joweich

joweich commented 11 months ago

@smty2018 Feel free to add the examples to this PR, we'll then have everything in the same place :+1:

smty2018 commented 11 months ago

@smty2018 Feel free to add the examples to this PR, we'll then have everything in the same place πŸ‘

okay, will commit to this branch only then.

smty2018 commented 10 months ago

@joweich added an example , can you please review it?

joweich commented 10 months ago

@smty2018 Thank you for your contribution and congrats to being on the main branch! :rocket: I only made some minor adjustments and merged directly.