search

joweich / chat-miner

Parsers and visualizations for chats
MIT License
567 stars 56 forks source link

added raw string or double backslashes for file_path #116

Closed smty2018 closed 11 months ago

smty2018 commented 11 months ago

Adding in ReadMe to use double backslashes or raw string for FILEPATH

Issue #115

codecov-commenter commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (d27bcb0) 61.23% compared to head (517cd9b) 61.23%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #116 +/- ## ======================================= Coverage 61.23% 61.23% ======================================= Files 2 2 Lines 325 325 ======================================= Hits 199 199 Misses 126 126 ``` | [Flag](https://app.codecov.io/gh/joweich/chat-miner/pull/116/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Weich) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/joweich/chat-miner/pull/116/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Weich) | `61.23% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Weich#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

smty2018 commented 11 months ago

@joweich can you please review this PR?

smty2018 commented 11 months ago

@smty2018 Thank you for your contribution! 🚀 I agree that bringing some guidance on how to read filepaths to the README makes sense, especially since this project is used by a lot of programming newcomers. I only have a minor suggestion to provide guidance for multiple source systems, not just Windows.

@joweich Thank you for your help

joweich commented 11 months ago

@smty2018 Congrats on your first contribution to chat-miner! :rocket: