joweich / chat-miner

Parsers and visualizations for chats
MIT License
567 stars 56 forks source link

fix missing name parameter in calendar_heatmap #133

Closed gutjuri closed 6 months ago

gutjuri commented 6 months ago

When calling calendar_heatmap I got an error that this line: https://github.com/joweich/chat-miner/blob/b7d0ea64f79677eea3fbcfb783a54b24c1a35949/chatminer/visualizations.py#L185 failed. This PR fixes this issue by manually setting the novel dataframe's columnname to "date" (previously it was "literal" for some reason.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.34%. Comparing base (b7d0ea6) to head (417e554).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #133 +/- ## ======================================= Coverage 90.34% 90.34% ======================================= Files 1 1 Lines 259 259 ======================================= Hits 234 234 Misses 25 25 ``` | [Flag](https://app.codecov.io/gh/joweich/chat-miner/pull/133/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Weich) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/joweich/chat-miner/pull/133/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Weich) | `90.34% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Weich#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gutjuri commented 6 months ago

pip install polars installed version 0.20.14 for me. Thanks for merging. Wasn't aware that this was my 5th contribution already ;P Time flies :D