search

joweich / chat-miner

Parsers and visualizations for chats
MIT License
566 stars 57 forks source link

Added functionality to process yyyy/MM/dd date format #54

Closed louispires closed 1 year ago

louispires commented 1 year ago

A couple of my friends had their exports come out in yyyy/mm/dd format and the current system could not process that.

Thus, I made a change to the Regex to also check for yyyy in the first column.

Then if the first column is actually a year, then select the day from the 3rd column

massimopavoni commented 1 year ago

A couple of my friends had their exports come out in yyyy/mm/dd format and the current system could not process that.

Thus, I made a change to the Regex to also check for yyyy in the first column.

Then if the first column is actually a year, then select the day from the 3rd column

That is quite interesting, do you have any idea of how come the export had a different time format? Correct me if I'm wrong, this is WhatsApp parser?

louispires commented 1 year ago

A couple of my friends had their exports come out in yyyy/mm/dd format and the current system could not process that. Thus, I made a change to the Regex to also check for yyyy in the first column. Then if the first column is actually a year, then select the day from the 3rd column

That is quite interesting, do you have any idea of how come the export had a different time format? Correct me if I'm wrong, this is WhatsApp parser?

Correct this is for WhatsApp parser.

I have no clue actually, but all my exports were fine, yet 3 friends asked me to do it for them as well and all of their dates were swapped around...

I checked the Android settings, but you can't really swap or set the date format...

joweich commented 1 year ago

@louispires thank you for your contribution! WhatsApp unfortunately has a lot of different export schema depending on OS, localization, version, and probably some more. Your implementation did not pass the tests for another datetime format during day_and_month = [int(num) for num in line.split(".")[:3]]. See details here While I'm not too happy with the way we currently set up our tests, it looks like this error is valid.

louispires commented 1 year ago

@louispires thank you for your contribution! WhatsApp unfortunately has a lot of different export schema depending on OS, localization, version, and probably some more. Your implementation did not pass the tests for another datetime format during day_and_month = [int(num) for num in line.split(".")[:3]]. See details here While I'm not too happy with the way we currently set up our tests, it looks like this error is valid.

I've made some changes and also ran the tests locally!

Should be good to go now.