joweich / chat-miner

Parsers and visualizations for chats
MIT License
567 stars 56 forks source link

Refactor dataframe wrangling in calendar heat map #99

Closed joweich closed 1 year ago

joweich commented 1 year ago

In calendar_heatmap (and to some extent in the other visualisations), we implicitly assume a certain dimensionality of the transformed dataframes (e.g. to have a scalar returned by df.min()). This should be made more explicit, e.g. by adding asserts or improve naming. Originally raised in #98.