jowilf / sqlalchemy-file

SQLAlchemy-file is a SQLAlchemy extension for attaching files to SQLAlchemy model and uploading them to various storage such as Local Storage, Amazon S3, Rackspace CloudFiles, Google Storage and others using Apache Libcloud.
https://jowilf.github.io/sqlalchemy-file/
MIT License
95 stars 12 forks source link

Add option to upload files by path #87

Closed adscib closed 1 year ago

adscib commented 1 year ago

This avoids having to load files into memory. I've been running this in production for some time now without issues, but it's certainly possible that this change breaks some behavior I'm not using, in particular when using positional arguments for File constructor. Let me know what you think.

adscib commented 1 year ago

I moved content_path to the end and added a test. I'm not familiar with the formatting checkers you're using, so I don't know what's up with that.

jowilf commented 1 year ago

Thank you for your contribution 🎉, I will try to fix the formatting issue