jowr / librefprop.so

Create a shared library from the Fortran sources provided by Refprop from NIST. This project provides an alternative to the refprop.dll that comes with the software. Please use the official instructions if possible
https://github.com/usnistgov/REFPROP-cmake
33 stars 8 forks source link

9.11 additional functions clash #31

Open ibell opened 9 years ago

ibell commented 9 years ago

In version 9.11 of REFPROP, the additional functions that are included in src/PASS_FTN_ALT.f are no longer needed since they are provided in REFPROP itself. Not sure how best to fix this, but I "fixed" it by commenting out these functions in src/PASS_FTN_ALT.f. Fun times.

jowr commented 9 years ago

Shouldn't we just rermove src/PASS_FTN_ALT.f from the sources?

ibell commented 9 years ago

Yes that would probably do it, but only if the REFPROP version is >=9.11

On Wed, Aug 12, 2015 at 4:10 AM, Jorrit Wronski notifications@github.com wrote:

Shouldn't we just rermove src/PASS_FTN_ALT.f from the sources?

— Reply to this email directly or view it on GitHub https://github.com/jowr/librefprop.so/issues/31#issuecomment-130248370.

ghost commented 9 years ago

Excluding it from the compilation process using the makefile would be better, I think, if the file is still distributed with REFPROP 9.11. Doing so, you don't delete it, and you don't need to comment the lines out.

jowr commented 9 years ago

Oh, that is what I meant: Remove it from the list of files to compile - not deleting it.

ghost commented 9 years ago

OK ! :-) ; Does somebody have a REFPROP 9.11 to test the code after the makefile has been modified? It seems that Ian has it. Do you also have a version at hand, Jorrit? Personally, I don't, but I can make the modification and make a pull request, as long as one of you test the code after that :-).