confusion about function: find_matches_in_hole

joxeankoret / diaphora

Diaphora, the most advanced Free and Open Source program diffing tool.

http://diaphora.re

GNU Affero General Public License v3.0

3.6k stars 371 forks source link

confusion about function: find_matches_in_hole #191

Closed xrkk closed 1 year ago

xrkk commented 4 years ago

as the name suggests, this function aims to find matches in hole range between 2 matched items. last indicates upper bound of the hole range. row indicates lower bound of the hole range. but, in the expression: cur.execute(sql, (id1+j, id2+i)), ida1+j and id2+i apparently below the lower bound of the hole range, which means, functions selected by this sql query are outside of the hole range. where am i wrong?

joxeankoret commented 4 years ago

I haven't looked at that code since I wrote it so, I'm sure there are a gazilion things wrong. I'm adding this to a (not so long) list of things to review and potentitally refactor. Thank you for pointing me to this!

joxeankoret commented 1 year ago

This is fixed in Diaphora 3.0, to be released soon. If you want to try to beta, tell me and I will send you it.