joxeankoret / diaphora

Diaphora, the most advanced Free and Open Source program diffing tool.
http://diaphora.re
GNU Affero General Public License v3.0
3.6k stars 371 forks source link

Warn users if they are using Python2 instead of Python3 in Diaphora master version #206

Closed shiftre closed 3 years ago

shiftre commented 3 years ago

I wanted to diff using Diaphora in my IDA 7.5 version, however as I was using Python2 I got a few exceptions, (especially when dealing with bytes vs ints), as I thought it's a bug I went over the sources and noticed the README.md states that diaphora it is working on Pyhton 3 however there is no check that identifies that, thus making Diaphora break or run recklessly on older Python versions.

I added a simple warning to hint users that they are doing something weird.

hth 💙

Cheers, Guy

joxeankoret commented 3 years ago

Thank you very much!!!