search

joxeankoret / diaphora

Diaphora, the most advanced Free and Open Source program diffing tool.
http://diaphora.re
GNU Affero General Public License v3.0
3.62k stars 372 forks source link

Possible typos and bugs #212

Closed Ziv00s3 closed 3 years ago

Ziv00s3 commented 3 years ago

Same heuristic? Looks like duplicate

https://github.com/joxeankoret/diaphora/blob/e04ed112e3b76c81812f976e8b6a5649c712e2b9/diaphora_heuristics.py#L650 https://github.com/joxeankoret/diaphora/blob/e04ed112e3b76c81812f976e8b6a5649c712e2b9/diaphora_heuristics.py#L701

Wrong parentheses?

{}->[] https://github.com/joxeankoret/diaphora/blob/e04ed112e3b76c81812f976e8b6a5649c712e2b9/diaphora_heuristics.py#L604

Numeric constant are checked and added to tuple/dict, but not saved to sqlite

https://github.com/joxeankoret/diaphora/blob/e04ed112e3b76c81812f976e8b6a5649c712e2b9/diaphora.py#L680 https://github.com/joxeankoret/diaphora/blob/e04ed112e3b76c81812f976e8b6a5649c712e2b9/diaphora_ida.py#L1507

Strings encoding/decoding

UTF-16 strings have wrong representation in sqlite. Like this: "NTFS" -> "NNTTFFSS"

joxeankoret commented 3 years ago

Thank you very-very-very much for the reports! Most of them are already fixed and I just need to run the tests to verify nothing was broken. The only thing I cannot reproduce is the bug with UTF-16 strings. If you could share any binary where it reproduces, I would be very thankful.

joxeankoret commented 3 years ago

Closing for now, as I cannot reproduce the UTF-16 strings problem and the other bugs were fixed. Feel free to reopen it.