search

joxeankoret / diaphora

Diaphora, the most advanced Free and Open Source program diffing tool.
http://diaphora.re
GNU Affero General Public License v3.0
3.58k stars 371 forks source link

Fix deleting items from Unmatched tabs #236

Closed CookiePLMonster closed 1 year ago

CookiePLMonster commented 1 year ago

Deleting items from "Unmatched primary" and "Unmatched secondary" resulted in a crash, since the deletion code assumed that the view has at least 5 columns, while Unmatched views have only 3. This fix ensures such cases are handled gracefully.

joxeankoret commented 1 year ago

Thanks for reporting this! I think this should be fixed in a different way, but I'm integrating your patch as it is for now.

CookiePLMonster commented 1 year ago

I don't disagree, this probably could be done better - but I figured the proposed fix is the least invasive and the safest way to quickly get it to do what I need.