joxeankoret / diaphora

Diaphora, the most advanced Free and Open Source program diffing tool.
http://diaphora.re
GNU Affero General Public License v3.0
3.58k stars 371 forks source link

In dark mode the colors are not clear #254

Closed yooo1999 closed 1 year ago

yooo1999 commented 1 year ago

In IDA dark mode , in diff screen the colors are not clear

joxeankoret commented 1 year ago

Some ~4 persons complained about this. But the problem is that everyone is using, in general, a different IDA dark mode plugin or scheme. Please can you tell me which plugin are you using?

Mas0nShi commented 1 year ago

Some ~4 persons complained about this. But the problem is that everyone is using, in general, a different IDA dark mode plugin or scheme. Please can you tell me which plugin are you using?

The default theme dark is almost unreadable...

image
yooo1999 commented 1 year ago

@joxeankoret The default dark mode like @Mas0nShi show

joxeankoret commented 1 year ago

Uhm... To be honest, I don't know how to properly automate it. But I can do a very easy thing: a configuration file where, also, colours can be configured. So, in the case of people with uncommon colour schemes, like in these cases, you could choose your preferred colours. I would need to write a backport for Diaphora 2.X first and then integrate it into 3.0, but that's my problem, not yours :)

So, does it sound about right to you folks?

joxeankoret commented 1 year ago

In Diaphora 3.0 (to be released soon) this is handled by modifying the colours in diaphora_config.py. If you want to test the current beta tell me and I will send you it.