search

joxeankoret / diaphora

Diaphora, the most advanced Free and Open Source program diffing tool.
http://diaphora.re
GNU Affero General Public License v3.0
3.62k stars 373 forks source link

NLTK is required by IDA Magic String but not by Diaphora #278

Open joxeankoret opened 1 year ago

joxeankoret commented 1 year ago

As reported privately (and not by the first time), Diaphora complains when Python's NLTK toolkit is not installed when, in truth, it isn't required by Diaphora, as the only features from IDA Magic Strings that Diaphora uses is the ability to find compilation units.

So, either I extract from IDA Magic Strings the specific code I want and put it somewhere in a specific place for Diaphora, or I make the 'fork' of this plugin in Diaphora not complaining.

mazegen commented 11 months ago

I think it's all right if Diaphora requires the NLTK toolkit. My issue was that the requirement of NLTK toolkit is undocumented (AFAIK) - I had to wait one hour for the SQL database to be generated only to learn that "averaged_perceptron_tagger" is not installed.