search

joxeankoret / diaphora

Diaphora, the most advanced Free and Open Source program diffing tool.
http://diaphora.re
GNU Affero General Public License v3.0
3.51k stars 370 forks source link

crash in ida8.3 #288

Closed zh913457894 closed 7 months ago

zh913457894 commented 7 months ago

I use diaphora under ida8.3. diaphora version 3.1.1. I want to export ida database to sqlite, settings are all default options,only the 'to address' option has been modified. I tried it twice and got the same crash

The crash log is as follows：

Traceback (most recent call last):
  File "D:/gihub/diaphora-master-3.11/diaphora-master\diaphora_ida.py", line 1250, in export
    self.do_export(crashed_before)
  File "D:/gihub/diaphora-master-3.11/diaphora-master\diaphora_ida.py", line 1195, in do_export
    props = self.read_function(func)
  File "D:/gihub/diaphora-master-3.11/diaphora-master\diaphora_ida.py", line 2989, in read_function
    asm, assembly_addrs = self.extract_function_assembly_features(
  File "D:/gihub/diaphora-master-3.11/diaphora-master\diaphora_ida.py", line 2615, in extract_function_assembly_features
    keys.remove(base)
ValueError: list.remove(x): x not in list
[Diaphora: Thu Nov 30 10:14:42 2023] Removing crash file D:\img\XXXXXN002.2244B\sox.bin.sqlite-crash....
joxeankoret commented 7 months ago

This is the first time I see this bug. Can you please share a sample reproducing this? Because reading the source... I cannot figure out at all why is it failing.

joxeankoret commented 7 months ago

I believe I have fixed it. Feel free to reopen if you hit it again.