joxeankoret / diaphora

Diaphora, the most advanced Free and Open Source program diffing tool.
http://diaphora.re
GNU Affero General Public License v3.0
3.62k stars 373 forks source link

AttributeError: 'CIDABinDiff' object has no attribute 'delete_function' #291

Closed overfl0 closed 8 months ago

overfl0 commented 8 months ago

While importing files using the "import all" or "import selected" menu option, I got this error.

Traceback (most recent call last):
  File "diaphora\diaphora_ida.py", line 305, in activate
    return self.obj.OnCommand(sel, self.cmd_id)
  File "diaphora\diaphora_ida.py", line 496, in OnCommand
    self.bindiff.import_one(self.items[n])
  File "diaphora\diaphora_ida.py", line 1483, in import_one
    self.delete_function(ea1)
AttributeError: 'CIDABinDiff' object has no attribute 'delete_function'

By quickly skimming over the code, it looks like that function was indeed present some time ago, but was then removed, while some references to it were kept.

At this moment, I can see two references to it:

joxeankoret commented 8 months ago

Thank you very much for reporting! Fixed with 59017c5