suggestion: add to the doc to have LLVM in system PATH

joxeankoret / pigaios

A tool for matching and diffing source codes directly against binaries.

GNU General Public License v3.0

634 stars 67 forks source link

suggestion: add to the doc to have LLVM in system PATH #23

Closed saidelike closed 5 years ago

saidelike commented 5 years ago

One thing to add to the Windows installation doc is to make sure to tick "Add LLVM to the system PATH for all users" when installing llvm prebuilt binaries.

Otherwise the generated sbd.project contains an empty includes =

[GENERAL]
includes =
inlines = 0

And lots of errors occurs when using srcbindiff.py -export.

However if we tick the box, we get:

[GENERAL]
includes = "C:\Program Files\LLVM\lib\clang\7.0.0\include"
inlines = 0

joxeankoret commented 5 years ago

Oh, it's required in Windows, I didn't really know. Thanks for reporting!

joxeankoret commented 5 years ago

And fixed the README.md with f9a0664e422464dacc96c205b76a66aa65508694