joxeankoret / pigaios

A tool for matching and diffing source codes directly against binaries.
GNU General Public License v3.0
634 stars 67 forks source link

Several issues with sourceimp_ida.py #32

Open mgoffin opened 4 years ago

mgoffin commented 4 years ago

Hello!

I am new to the project and came across several issues thus far trying to use this script with the latest version of IDA Pro.

  1. Choose2 is gone. I replaced it with Choose and it seems to work but that doesn't seem like the best solution given the documentation I will link to later.

  2. askyn_c has been renamed to ask_yn

  3. TypeError: in method 'reg_write_string', argument 2 of type 'char const *'

    Can be fixed by adding a `.encode('utf-8') to the second argument.

  4. Message() isn't defined

  5. GetIdbPath() isn't defined

  6. MinEA() isn't defined

I stopped trying to fix things here because I feel like I must be doing something wrong to have all of these problems with no one else reporting them. But then I see lines like this:

self.db_filename = os.path.splitext(self.db_path)[0] + "-src.sqlite"

Which is the only reference to self.db_path in the entire script, and isn't mentioned at all in the class being inherited.

The documentation I looked at for some of this info is here: https://www.hex-rays.com/products/ida/7.0/docs/api70_porting_guide.shtml

joxeankoret commented 4 years ago

It doesn't support yet IDA 7.4, yes. I have almost finished porting it, but these days aren't the best to have time for open source development so, very likely, I won't be able to finish it until mid-January.

mgoffin commented 4 years ago

Thanks! Is there a branch of that port available? I'd be interested to look at it, possibly contribute if it's something I can figure out. I am very new to all of this.

joxeankoret commented 4 years ago

Not yet. I usually publish my changes when they are ready and never publish partial commits.