search

joy-framework / joy

A full stack web framework written in janet
https://joy.swlkr.com
MIT License
532 stars 29 forks source link

Dockerfile improvements #78

Closed oz123 closed 3 years ago

oz123 commented 3 years ago

As discussed in #77 I made the update. I added one more tiny change which seemed fit. Instead of having to frequently update janet language in the docker file, you can now pass it as a built time argument:

docker build --build-arg JANET=1.12.1 -f docker/Dockerfile .

I hope this is fine.

swlkr commented 3 years ago

Oh my gosh the build arg, goes to show how much I know about docker

oz123 commented 3 years ago

The CI fails because I lack permission. i think you can safely merge.