search

joyent / conch-api

Datacenter build and management service
Mozilla Public License 2.0
22 stars 11 forks source link

Net::MAC::Vendor introduces an XS dep unnecessarily #349

Closed bdha closed 5 years ago

bdha commented 6 years ago

We use this module to read the OUI database from IEEE to map MAC addresses to the device vendor.

In our deployment, we want to distribute the database plaintext directly, and so do not need to uncompress the file (using Compress:Bzip2 or Compress::Zlib). We want to limit new XS deps in the API -- and using the same module in conch-reporter-smartos, where XS deps are contraindicated.

It would be helpful if Net::MAC::Vendor only optionally required the compression modules if a local source is not specified.

karenetheridge commented 6 years ago

patch prepared at https://github.com/briandfoy/net-mac-vendor/pull/27.

karenetheridge commented 5 years ago

The patch has been applied, but not yet released to cpan.

karenetheridge commented 5 years ago

The patch has now been released to cpan as Net-MAC-Vendor-1.263.