search

joyent / conch-ui

Web UI for Conch (https://github.com/joyent/conch-api)
2 stars 5 forks source link

"Builds" link does not work for non-systemadmins #235

Closed karenetheridge closed 3 years ago

karenetheridge commented 4 years ago

Clicking on "Builds" in the left sidebar as an unprivileged user results in an infinite spinner for many of the build cells (every build that the user doesn't have the ability to view). Information is bleeding over from previous logins where a different user could see more builds, and the UI is attempting to populate data for all those builds as well, rather than just the builds returned from GET /build (which is restricted to those the user has permissions for).

karenetheridge commented 4 years ago

Similarly, clicking "Profile" also hangs -- in the console I see submitted to the API: GET .../user/undefined/token and GET .../user/<wrong userid>, both of which return 403.

karenetheridge commented 4 years ago

After logging out and logging in again, now "Profile" shows user data for the wrong user instead of just hanging.

karenetheridge commented 4 years ago

This is still occurring today.

dustinryerson commented 3 years ago

This is fixed in production.