search

joyent / conch-ui

Web UI for Conch (https://github.com/joyent/conch-api)
2 stars 5 forks source link

adding links: errors are not cleared after a subsequent successful entry #245

Closed karenetheridge closed 3 years ago

karenetheridge commented 4 years ago

When adding a link, and the link is in the wrong format, an error is displayed. Then, after successfully adding a link, the previous error is not cleared.

Also, GET /device/:id is called twice after the link is POSTed.

Screen Shot 2020-08-28 at 3 04 32 PM

karenetheridge commented 3 years ago

this issue seems to still exist.

dustinryerson commented 3 years ago

Just tested this on edge and it's working now. I added a poorly formatted link, clicked the Add Link button and got the error message. I then entered a properly formatted link, clicked the Add Link button and the link was added and the error message was removed.

dustinryerson commented 3 years ago

I've verified that this has been fixed on production. Please feel free to reopen if I've missed something.