search

joyent / conch-ui

Web UI for Conch (https://github.com/joyent/conch-api)
2 stars 5 forks source link

failed user login is not handled correctly #262

Closed karenetheridge closed 3 years ago

karenetheridge commented 3 years ago

As discussed in MM last week -- when the user enters an invalid password at the login page, the 401 response is being sent back to the browser which kicks up a default user auth form.

Screen Shot 2020-09-24 at 2 37 41 PM

dustinryerson commented 3 years ago

This is being caused by the WWW-Authenticate header being returned in the response, which was added to the API here: https://github.com/joyent/conch-api/pull/985

karenetheridge commented 3 years ago

I still think it's odd that the response (and its headers) is being seen by the browser rather than being captured by the js that made the request. The API does not structure its responses with the browser in mind.

dustinryerson commented 3 years ago

This issue has been resolved by https://github.com/joyent/conch-api/pull/1042.