search

joyent / git-apply-pr

Validate GitHub PullRequests and add metadata
MIT License
8 stars 4 forks source link

Fix lgtm #17

Closed robertkowalski closed 8 years ago

robertkowalski commented 8 years ago

This PR makes the module testable, adds test and fixes the regression from #10

PTAL @misterdjules @riyadhalnur

riyadhalnur commented 8 years ago

:+1:

misterdjules commented 8 years ago

@robertkowalski Thank you very much for doing this! I left a few comments, I think once these comments are addressed, the changes would look good to me. We would need to squash the commits into one commit with a good description similar to what you wrote in the PR's description.

robertkowalski commented 8 years ago

@misterdjules thank you for the great review! it is fun to get such good feedback. code looks better now. ptal.

misterdjules commented 8 years ago

LGTM, thank you once again @robertkowalski for doing this!

misterdjules commented 8 years ago

@robertkowalski I forgot to mention that the commits need to be squashed into one commit.

robertkowalski commented 8 years ago

done, thank you!

pubished as 1.2.3

robertkowalski commented 8 years ago

merged as b80e73d