Closed robertkowalski closed 8 years ago
:+1:
@robertkowalski Thank you very much for doing this! I left a few comments, I think once these comments are addressed, the changes would look good to me. We would need to squash the commits into one commit with a good description similar to what you wrote in the PR's description.
@misterdjules thank you for the great review! it is fun to get such good feedback. code looks better now. ptal.
LGTM, thank you once again @robertkowalski for doing this!
@robertkowalski I forgot to mention that the commits need to be squashed into one commit.
done, thank you!
pubished as 1.2.3
merged as b80e73d
This PR makes the module testable, adds test and fixes the regression from #10
PTAL @misterdjules @riyadhalnur