grr could check current patchset parent

joyent / grr

A `grr` CLI tool to help use Joyent's CR tool, Gerrit (https://cr.joyent.us)

1 stars 4 forks source link

grr could check current patchset parent #12

Open jlevon opened 5 years ago

jlevon commented 5 years ago

As seen in https://cr.joyent.us/#/c/6010/

I think what happened here is that patchset 2 had a parent 1df0262127ba10f20347daae7ac94c0d44fcd150

Then I rebased in Gerrit, and ran grr again. Because this then rebased back to a previous parent, and modified the commit message, I lost my CRs.

It would be great if grr could notice that the current patchsets parent is different (an ancestor?) of the current local one, and refuse to upload by default.

trentm commented 5 years ago

^^ I accidentally referred to issue #12 (this one) instead of issue #13 in those commits.