search

joyent / libuv

Go to
https://github.com/libuv/libuv
3.27k stars 653 forks source link

win: return libuv error codes in uv_poll_init() #1520

Closed cjihrig closed 10 years ago

cjihrig commented 10 years ago

Currently, uv_poll_init() returns the result of WSAGetLastError() on error. This commit wraps the error with a call to uv_translate_sys_error().

Closes #1518

trevnorris commented 10 years ago

Seems there are several locations where WSAGetLastError() is returned. Think those should be wrapped as well?

saghul commented 10 years ago

@trevnorris all functions that return values to the user should have the value translated, but on Windows not all functions return directly, so translation happens later on.

saghul commented 10 years ago

Thanks Colin! Landed in 416b733

cjihrig commented 10 years ago

Thanks. #1518 can probably be closed too I think.