search

joyfullservice / msaccess-vcs-addin

Synchronize your Access Forms, Macros, Modules, Queries, Reports, and more with a version control system.
Other
203 stars 40 forks source link

PrtMip Scrubbed from forms on export (discrepancy between joyfullservice and 'head' export) #115

Closed hecon5 closed 3 years ago

hecon5 commented 3 years ago

So, I FINALLY got this addin to work (thanks to RubberDuck VBA reference manager!).

I've begun the process of verifying exports from the two tools, and I've noticed that "

PrtMip = Begin  
...(key)...
End

Seems to be scrubbed during your sanitize routine. What is this attribute/value for, and should I ignore it?

(also, holy smokes, that's a lot faster!)

hecon5 commented 3 years ago

This is nice: image

Export/Import matches! Now to clean up.

I'm going to ignore the above suggestion (of mine) and just make a PR for the relevant bits that I changed; I think it reads fine as-is, and allows a tad more control, not to mention reduces the likelihood (certainty) I'll fat finger something while cleaning it up.

joyfullservice commented 3 years ago

One other thing I notice is that you don't use .AppendOnAdd = vbCrLf;

That's only because I hadn't written AppendOnAdd yet, but yes, this is exactly the type of situation where it is helpful. 😄 I will probably go ahead and add that in since it improves readability.

joyfullservice commented 3 years ago

I am still seeing an issue with the PrtMip section where a full round-trip conversion changes something in the Datasheet flag.

image

Investigating this further... (I believe it should be coming through as 1, not 2097153.)

image

joyfullservice commented 3 years ago

Got it! Sometimes it is the little things... 😄 The byte array buffer was incorrectly sized, which meant that when LSet tried to apply the string buffer to the type, the 2 missing bytes at the end threw off the representation of the Datasheet flag. This caused the unexpected output with what should have been a 0 or 1.

If this all works as expected in your testing, I think we might finally be ready to close out this issue. 😄

hecon5 commented 3 years ago

Success! I think we can close this!