search

joyfullservice / msaccess-vcs-addin

Synchronize your Access Forms, Macros, Modules, Queries, Reports, and more with a version control system.
Other
211 stars 41 forks source link

Export source from Ribbon: frmVCSMain does not stay open if ErrorLevel > eelWarning (AutoClose) #494

Closed josef-poetzl closed 4 months ago

josef-poetzl commented 8 months ago

When Export Source is started from the ribbon, the main form does not remain open despite an error message. AutoClose is always triggered.

Cause: Log.ErrorLevel is always 0, as the log instance in the export methods is destroyed. see: https://github.com/josef-poetzl/msaccess-vcs-addin/commit/6cdb15bf3e9f37fb993dc8c74dce2cd0a5453ed9

Fix: https://github.com/josef-poetzl/msaccess-vcs-addin/commit/36948e5f551e2db6dc250b4c08aad7d05e3e922c

joyfullservice commented 7 months ago

@josef-poetzl - Thanks for pointing this out! I like the concepts you implemented in the suggested fix. But as I dug into it a little deeper, I think I found an underlying issue that may solve this in an even more elegant way.

As you pointed out the Log instance is destroyed by the call to ReleaseObjects. Stepping through the code, this actually happens twice, once as the export finishes, and a second time as the clsVersionControl class is terminated.

Ideally, I would like to persist the log object during the duration of the entire operation triggered by the ribbon button click. This will allow the form UI code to check the Log.ErrorLevel after the conclusion of the export, but before the form is closed. When the clsVersionControl class terminates at the conclusion of the entire operation, the objects are released. I believe that by removing the redundant (early) calls to ReleaseObjects, we can resolve this issue.

josef-poetzl commented 7 months ago

Tested: works fine

I still made this adjustment: https://github.com/josef-poetzl/msaccess-vcs-addin/commit/ea1a37e620130a5a55728f0fe6a572a84cc749b3 => to allow add enum items between Warning and Error Note: This is a test branch where I test the interface for AccUnit - with minimal customization of the msaccess-vcs-addin. (see: https://github.com/joyfullservice/msaccess-vcs-addin/discussions/493)

Screenshot of example log: https://www.access-programmers.co.uk/forums/attachments/msaccess-vcs-testfailedwarning-png.113036/

hecon5 commented 4 months ago

If this is working @josef-poetzl, can you close it? Thank you!