search

joyhughes / Jen

Image processing, generative photography, cellular automata
https://discord.gg/GQQHUbkf
20 stars 20 forks source link

Default dark mode #116

Closed joyhughes closed 1 month ago

joyhughes commented 1 month ago

Add a gear icon to the right of the media controller. Use a pull-down menu to toggle dark mode. Later there will be more on the menu but right now only dark mode. Dark mode is enabled by default.

NaunihalSingh40 commented 1 month ago

Hi @joyhughes Naunihal Singh this side from Gssoc, making dark mode the default one is a great task to do. I request you to assign this task to me.

I will be glad to have this opportunity!

joyhughes commented 1 month ago

@NaunihalSingh40 Assigned to you Learn more about project here: https://www.youtube.com/watch?v=vN1ApdESIrc Please ask any questions you may have

NaunihalSingh40 commented 1 month ago

I have tried doing it but some components color wont change even after the class names are the same as required at console, here's a preview:

https://github.com/joyhughes/Jen/assets/109708929/13170545-bd45-4dae-893d-4217797e6205

joyhughes commented 1 month ago

I have tried doing it but some components color wont change even after the class names are the same as required at console, here's a preview: d.mode.mp4

I will look at this during the day (night time in India) today and advise you.

joyhughes commented 1 month ago

@NaunihalSingh40 Are you familiar with MUI (Material UI)? I believe you will need to set the palette mode: https://mui.com/material-ui/customization/dark-mode/

joyhughes commented 1 month ago

@NaunihalSingh40 If you have any questions or need help let me know - I will work with you on this issue.

joyhughes commented 1 month ago

@NaunihalSingh40 Join the Lux Vitae discord channel https://discord.gg/EmmfUEeA

joyhughes commented 1 month ago

@NaunihalSingh40 Watch the Lux Vitae video https://www.youtube.com/watch?v=vN1ApdESIrc

NaunihalSingh40 commented 1 month ago

Hello @joyhughes I have successfully done the default dark mode task, thanks for the guidance without which it might gone difficult to do the task, I have learnt a lot in this task! Here's a preview for the lux app with default dark mode:

https://github.com/joyhughes/Jen/assets/109708929/98a9d7f4-bf0e-4712-92a5-852ec8b49d7f

joyhughes commented 1 month ago

@NaunihalSingh40 Congratulations on your success! You may submit a PR.

NaunihalSingh40 commented 1 month ago

is it done? if any other issue to work upon you may convey me for the same.