search

joyhughes / Jen

Image processing, generative photography, cellular automata
https://discord.gg/GQQHUbkf
20 stars 20 forks source link

Create greetings.yaml #122

Closed sanmarg closed 1 month ago

sanmarg commented 1 month ago

Added for #106

rudi-cilibrasi commented 1 month ago

nice

joyhughes commented 1 month ago

I have made some small changes. When Discord channels are ready I will add a request to join. PR is approved.

rudi-cilibrasi commented 1 month ago

Convention is for author to merge PR's https://softwareengineering.stackexchange.com/questions/334488/code-review-workflow-where-pull-request-author-must-merge

rudi-cilibrasi commented 1 month ago

@sanmarg i saw you like docker in your blog. this project uses Docker for cicd but it only does one kind of build using clang-12. it needs to also install react or vite dependencies in the docker image and then devs can run the react or vite frontend webserver using docker with a tcp port hole punch in say port 3000 or maybe --net=host

i just wanted to mention the need to you in case you are interested. there is also a need for an emscripten build (in addition to the clang-12 build we already check in cicd) to go into the react/vite frontend. ideally devs can then run docker container locally to see the changes they are making work etc

sanmarg commented 1 month ago

Sure I'll look into it