joyhughes / Jen

Image processing, generative photography, cellular automata
https://discord.gg/GQQHUbkf
20 stars 20 forks source link

Fibonacci Spiral Vector and Warp Fields #141

Open joyhughes opened 1 month ago

joyhughes commented 1 month ago

Create a spiral vector field such that advecting from any point will produce a Fibonacci spiral. This will be used in the Kaleidoswirl scene ( issue #140 ) and for targeting warps in cellular automata.

kairveeehh commented 1 month ago

@joyhughes would like to work on it as a problem solving enthusiast under gssoc'24 but need to know whether you want just the c++ implementation of the field or smt else?

vinay-sagar123 commented 1 month ago

hello sir, can you assign this issue to me. I have started work on it.

lassmara commented 1 month ago

please assign me this issue

joyhughes commented 1 month ago

@joyhughes would like to work on it as a problem solving enthusiast under gssoc'24 but need to know whether you want just the c++ implementation of the field or smt else?

It is C++ implementation of vector field as well as creating an effect that can be stored in the scene, and a scene file for testing.

joyhughes commented 1 month ago

hello sir, can you assign this issue to me. I have started work on it.

Interesting! What have you done so far?

kairveeehh commented 1 month ago

hello sir, can you assign this issue to me. I have started work on it.

Interesting! What have you done so far?

i have the complete code ready in c++ please tell me how it needs to be added just

joyhughes commented 1 month ago

hello sir, can you assign this issue to me. I have started work on it.

Interesting! What have you done so far?

i have the complete code ready in c++ please tell me how it needs to be added just

If it is ready just submit PR

kairveeehh commented 1 month ago

no I mean I have a c++ code that works on input /output based ready , can share or create a PR of the same but I need you to explain how it needs to be added

joyhughes commented 1 month ago

no I mean I have a c++ code that works on input /output based ready , can share or create a PR of the same but I need you to explain how it needs to be added

I'm interested in seeing what you've written so far.

Calculations for vector fields happen in the vftools class in vector_field.cpp ... then an effect functor in effect.cpp with harness functors for each parameter that can be changed. A smart pointer to the effect functor needs to be added to the variant any_effect_fn_ptr in any_effect.hpp and a line for loading the function needs to go into scene_io.cpp. The kaleido.json scene file can be modified to test.

If you learn how to do this one time there will be multiple issues with the same general format - writing a function or effect, adding to the variants and I/O and testing in a scene file.

kairveeehh commented 1 month ago

Yea this was what i needed right now I have a c++ code that generates a Fibonacci spiral upon execution will add it to Pr

joyhughes commented 1 month ago

Yea this was what i needed right now I have a c++ code that generates a Fibonacci spiral upon execution will add it to Pr

Did you have a chance to take a look at it?

kairveeehh commented 1 month ago

Yea this was what i needed right now I have a c++ code that generates a Fibonacci spiral upon execution will add it to Pr

Did you have a chance to take a look at it?

yea I did but I want to ask that I am just adding a c++ code right now is that fine ?

joyhughes commented 1 month ago

Yes I can handle the scene file JSON


From: kairvee @.> Sent: Sunday, June 2, 2024 11:08:57 PM To: joyhughes/Jen @.> Cc: Joy Hughes @.>; Mention @.> Subject: Re: [joyhughes/Jen] Fibonacci Spiral Vector and Warp Fields (Issue #141)

Yea this was what i needed right now I have a c++ code that generates a Fibonacci spiral upon execution will add it to Pr

Did you have a chance to take a look at it?

yea I did but I want to ask that I am just adding a c++ code right now is that fine ?

— Reply to this email directly, view it on GitHubhttps://github.com/joyhughes/Jen/issues/141#issuecomment-2144351254, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKBIGEGC2BEZGZQFMC2FDETZFQB7TAVCNFSM6AAAAABIGCMI56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBUGM2TCMRVGQ. You are receiving this because you were mentioned.Message ID: @.***>

joyhughes commented 2 weeks ago

@kairveeehh do you have any more questions about this?