joypixels / emoji-toolkit

The world's largest independent emoji font.
https://www.joypixels.com
Other
434 stars 47 forks source link

Wrong license definition in package.json #38

Open joeson1 opened 4 years ago

joeson1 commented 4 years ago

NPM defines the license to be given differently than it is currently done: https://docs.npmjs.com/files/package.json#license

Current situation:

"licenses": { "type": "(MIT)", "url": "https://github.com/joypixels/emoji-toolkit/blob/master/LICENSE.md" },

Should be like:

"license" : "MIT"

The files property can be used to distribute the LICENSE.md file if necessary: https://docs.npmjs.com/files/package.json#files

Why it came up: we have tools to generate the 3rd party component disclosure documents that are crawling all node modules. It's failing with this package because it cannot parse.

joeson1 commented 4 years ago

37