search

joypixels / emojify.js

A Javascript module to convert Emoji keywords to images
http://hassankhan.github.io/emojify.js/
MIT License
1.8k stars 238 forks source link

Run tests on Windows with Appveyor #109

Closed adam-lynch closed 10 years ago

adam-lynch commented 10 years ago

I can sort this. I've done it for a lot of projects already

hassankhan commented 10 years ago

Yeah that sounds cool, although if it runs on node isn't it guaranteed to run on any platform where node is installed?

adam-lynch commented 10 years ago

Yes but a dependency could broken on Windows or our logic could be broken.

For example: https://github.com/aslansky/css-sprite/pull/29. They used path.join to join the base URL to the image filename but path.join uses the system's path separator so it was broken on Windows because the resultant path was images\spritesheet.png or something like that.

adam-lynch commented 10 years ago

It's very little work anyway to have our tests run in four more test environments; on Node 0.10 & 0.11, both on Windows 32-bit & 64-bit. So that's good :smile:

hassankhan commented 10 years ago

Oh right, just thought I'd ask, I was sure you had a good reason :+1:

hassankhan commented 10 years ago

FYI I'll make you a collaborator on this repo later tonight hopefully

adam-lynch commented 10 years ago

Cool thanks

hassankhan commented 10 years ago

Done

adam-lynch commented 10 years ago

:smile:

adam-lynch commented 10 years ago

One thing to note here is that the tests ran with phantomjs don't show any output when they all pass, but they do when something goes wrong so that's ok. (Look at the end of the logs at those links)

Also, a dependency of css-sprite uses node-gyp (ugh) which breaks the builds on Node 0.11 for some reason but that's ok because failures are allowed for the latest versions; see https://github.com/hassankhan/emojify.js/blob/develop/appveyor.yml#L7.