joypixels / emojify.js

A Javascript module to convert Emoji keywords to images
http://hassankhan.github.io/emojify.js/
MIT License
1.8k stars 238 forks source link

Moving towards a 1.0 release #41

Closed hassankhan closed 9 years ago

hassankhan commented 10 years ago

Just throwing around ideas here for a v1.0 release.

Config options

Relevant issue

Emoji sets

Relevant issue

Task runner

Also, I've started using Gulp and I've got to say it seems a lot nicer to use than Grunt, so maybe switch over to Gulp too. @adam-lynch has volunteered!

Obviously every task should be available as it was before, but I also think Gulp allows some more flexibility, and we can take advantage of that with new tasks. The best example I can think of is porting the update.sh file over.

This might take longer because a Gulp task doesn't seem to be working for me.

What do you guys think? @qq99 @suprememoocow

qq99 commented 10 years ago

I like the sounds of blacklist for specific emoji :+1:

hassankhan commented 10 years ago

Use shim for IE8 and co.

Relevant issue

Spritesheets

Relevant issue

adam-lynch commented 10 years ago

I can do the Grunt -> Gulp conversion.

@hassankhan FYI, the links in your second comment there are broken.

adam-lynch commented 10 years ago

Moving to Gulp needs to wait til #47 is merged I guess.

adam-lynch commented 10 years ago

An even better table of emoji: http://emoji.codes/family

hassankhan commented 10 years ago

Cleanup project root

Relevant issue

BenMQ commented 10 years ago

I'm interested in helping out with the Config options enhancement, I find it useful in my own usage :smiley:

hassankhan commented 10 years ago

Automate version bumping

Relevant issue

hassankhan commented 10 years ago

Add emojify.js to a CDN

Relevant issue

hassankhan commented 10 years ago

Remove images directory

Now part of this issue

hassankhan commented 10 years ago

Support Node environment properly

Relevant issue Relevant issue

hassankhan commented 10 years ago

Add code coverage results

Relevant issue

adam-lynch commented 10 years ago

Grunt -> Gulp done; #85.

@hassankhan would you be open to creating a Trello / waffle.io board for this repo? It would make it easier to complete all these tasks.

hassankhan commented 10 years ago

Have you perchance got ZenHub installed on Chrome? I installed it yesterday, has a pretty good board (or at least I thought so)

adam-lynch commented 10 years ago

@hassankhan this looks good. Do you have a project for emojify.js on it? How do I access?

adam-lynch commented 10 years ago

We should make a new release now. We have added some major features; full Node support, sprites, etc. There are no real outstanding or ongoing PRs so it'll be a long time before we get all of these features done for version 1.0.

@hassankhan give me the go ahead and I'll publish to npm :smile: (and of course merge develop into master)

hassankhan commented 10 years ago

Yep, I agree. Last thing I wanted to do was integrate the failing test PRs (#62 and #57) and see if those've been fixed. If that's all good, I think it's time to release 1.0!!

hassankhan commented 10 years ago

Oh, actually there was one more thing I wanted to do: tidy up config options. I'll try and find some time this weekend to land that, then I'm happy for you to release.

BTW, can you even submit to npm for me? I thought I had to update my npm packages myself :confused:

adam-lynch commented 10 years ago

57 is less important since everything is supported in Node now. It's less likely that someone will pass a HTML string to replace. I created it and I won't be using replace anymore probably. It should be fixed but not urgently.

For tidying up the config options, can you create an issue clearly defining what the config should be?

BTW, can you even submit to npm for me? I thought I had to update my npm packages myself :confused:

Yeah. See node-webkit-builder (I'm listed as a maintainer) for example. I think you need to run npm owner add adam-lynch emojify.js, see npm-owner.

hassankhan commented 10 years ago

There's an open issue (#87) for the config options. I'll run the npm owner command when I get home later tonight, hopefully :smile: Might also be worth adding npm publish to the gulp release command

adam-lynch commented 9 years ago

How about a version 1.0 now? It's a shame those changes aren't out there.

P.S. Did you add me as an owner to the npm package? :smiley:

adam-lynch commented 9 years ago

ping

hassankhan commented 9 years ago

Hiya, sorry it's been mental at work launching a few campaigns, will probably do the release over the Xmas break

adam-lynch commented 9 years ago

@hassankhan if you add me as an owner to the npm package then I can make the release.

4ver commented 9 years ago

@hassankhan @adam-lynch Ye could make a 0.10.0 release and wait for the api change to release 1.0 ?

adam-lynch commented 9 years ago

:frowning: Ok, we think we will have to fork this and maintain it ourselves. This project moves far too slowly. It's very frustrating. We added big features as far back as October (which we need) which still aren't released.

We've been trying to work using the develop branch and it's not working out (one related issue: #114). We need versions to be published to npm.

Also, we want Emoji One support so we think we'd have that done and released faster if we maintained our own project.

hassankhan commented 9 years ago

I'd prefer a 0.10 release first, before I get some time to redo the options.

hassankhan commented 9 years ago

v1.0 is finally out, thanks everyone!